Merge pull request #319 from ZoiteChat/css-use-after-free-fix

Fix channel tree font ownership/lifetime

src/common/inbound.c

@@ -1815,14 +1815,14 @@ inbound_login_end (session *sess, char *text, const message_tags_data *tags_data
 			return;
 
 		/* send nickserv password */
-		if (net && serv->password[0] && inbound_nickserv_login (serv))
+		if (net && net->pass && inbound_nickserv_login (serv))
 		{
-			serv->p_ns_identify (serv, serv->password);
+			serv->p_ns_identify (serv, net->pass);
 		}
 
 		/* wait for join if command or nickserv set */
 		if (net && prefs.hex_irc_join_delay
-			&& ((serv->password[0] && inbound_nickserv_login (serv))
+			&& ((net->pass && inbound_nickserv_login (serv))
 				|| net->commandlist))
 		{
 			serv->joindelay_tag = fe_timeout_add_seconds (prefs.hex_irc_join_delay, check_autojoin_channels, serv);

src/common/outbound.c

@@ -4868,9 +4868,9 @@ command_insert_vars (session *sess, char *cmd)
 				break;
 
 			case 'p':
-				if (sess->server->password[0])
+				if (mynet->pass)
 				{
-					g_string_append (expanded, sess->server->password);
+					g_string_append (expanded, mynet->pass);
 				}
 				cmd++;
 				break;

src/fe-gtk/chanview.c

@@ -79,6 +79,8 @@ struct _chanview
 	guint theme_listener_id;
 };
 
+static void chanview_set_font_desc (chanview *cv, const PangoFontDescription *font_desc);
+
 struct _chan
 {
 	chanview *cv;	/* our owner */
@@ -169,6 +171,7 @@ chanview_apply_theme (chanview *cv)
 	w = GTK_WIDGET (tv->tree);
 	if (input_style)
 		font = input_style->font_desc;
+	chanview_set_font_desc (cv, font);
 
 	theme_manager_apply_channel_tree_style (w,
 			theme_manager_get_channel_tree_palette_behavior (font));
@@ -313,6 +316,14 @@ chanview_free_ch (chanview *cv, GtkTreeIter *iter)
 	g_free (ch);
 }
 
+static void
+chanview_set_font_desc (chanview *cv, const PangoFontDescription *font_desc)
+{
+	if (cv->font_desc)
+		pango_font_description_free (cv->font_desc);
+	cv->font_desc = font_desc ? pango_font_description_copy (font_desc) : NULL;
+}
+
 static void
 chanview_destroy_store (chanview *cv)	/* free every (chan *) in the store */
 {
@@ -335,6 +346,9 @@ chanview_destroy (chanview *cv)
 	if (cv->box)
 		gtk_widget_destroy (cv->box);
 
+	if (cv->font_desc)
+		pango_font_description_free (cv->font_desc);
+
 	chanview_destroy_store (cv);
 	g_free (cv);
 }
@@ -356,7 +370,7 @@ chanview_new (int type, int trunc_len, gboolean sort, gboolean use_icons,
 	cv = g_new0 (chanview, 1);
 	cv->store = gtk_tree_store_new (5, G_TYPE_STRING, G_TYPE_POINTER,
 							  PANGO_TYPE_ATTR_LIST, GDK_TYPE_PIXBUF, G_TYPE_INT);
-	cv->font_desc = font_desc;
+	cv->font_desc = font_desc ? pango_font_description_copy (font_desc) : NULL;
 	cv->box = gtk_box_new (GTK_ORIENTATION_HORIZONTAL, 0);
 	cv->trunc_len = trunc_len;
 	cv->sorted = sort;

src/fe-gtk/fe-gtk.c

@@ -1357,17 +1357,19 @@ fe_open_url_inner (const char *url)
 	gboolean opened = FALSE;
 
 #ifdef WIN32
-	opened = g_app_info_launch_default_for_uri (escaped_url, NULL, &error);
+	gunichar2 *url_utf16 = g_utf8_to_utf16 (escaped_url, -1, NULL, NULL, NULL);
+
+	if (url_utf16 != NULL)
+	{
+		opened = ((INT_PTR) ShellExecuteW (0, L"open", url_utf16, NULL, NULL, SW_SHOWNORMAL)) > 32;
+		g_free (url_utf16);
+	}
+
 	if (!opened)
 	{
-		g_clear_error (&error);
+		opened = g_app_info_launch_default_for_uri (escaped_url, NULL, &error);
-		gunichar2 *url_utf16 = g_utf8_to_utf16 (escaped_url, -1, NULL, NULL, NULL);
+		if (!opened)
-
+			g_clear_error (&error);
-		if (url_utf16 != NULL)
-		{
-			opened = ((INT_PTR) ShellExecuteW (0, L"open", url_utf16, NULL, NULL, SW_SHOWNORMAL)) > 32;
-			g_free (url_utf16);
-		}
 	}
 #else
 	{