Improve GTK3 Performance

src/fe-gtk/fe-gtk.h

@@ -114,7 +114,7 @@ typedef struct restore_gui
 
 	/* information stored when this tab isn't front-most */
 	GtkListStore *user_model;	/* for filling the GtkTreeView */
-	GHashTable *user_row_refs;
+	GHashTable *user_row_iters; /* User * -> persistent GtkTreeIter * */
 	void *buffer;		/* xtext_Buffer */
 	char *input_text;	/* input text buffer (while not-front tab) */
 	char *topic_text;	/* topic GtkEntry buffer */

src/fe-gtk/maingui.c

@@ -925,236 +925,10 @@ mg_send_reply_or_text (session *sess, char *cmd)
 	mg_reply_update (sess);
 }
 
-typedef struct
-{
-	gboolean bold;
-	gboolean italic;
-	gboolean underline;
-	gboolean strikethrough;
-	gboolean reverse;
-	gint foreground;
-	gint background;
-	gboolean pending_foreground;
-	gboolean pending_background;
-} MgInputFormatState;
-
-static void
-mg_input_format_state_at_cursor (GtkEntry *entry, MgInputFormatState *state)
-{
-	const char *text;
-	const char *cursor;
-	gsize limit;
-	gsize i;
-	gint cursor_pos;
-
-	memset (state, 0, sizeof (*state));
-	state->foreground = -1;
-	state->background = -1;
-
-	text = gtk_entry_get_text (entry);
-	cursor_pos = gtk_editable_get_position (GTK_EDITABLE (entry));
-	if (!text || cursor_pos < 0)
-		return;
-
-	cursor = g_utf8_offset_to_pointer (text, cursor_pos);
-	limit = (gsize) (cursor - text);
-
-	for (i = 0; i < limit;)
-	{
-		guchar ch = (guchar) text[i++];
-
-		switch (ch)
-		{
-		case ATTR_BOLD:
-			state->bold = !state->bold;
-			break;
-		case ATTR_ITALICS:
-			state->italic = !state->italic;
-			break;
-		case ATTR_UNDERLINE:
-			state->underline = !state->underline;
-			break;
-		case ATTR_STRIKETHROUGH:
-			state->strikethrough = !state->strikethrough;
-			break;
-		case ATTR_REVERSE:
-			state->reverse = !state->reverse;
-			break;
-		case ATTR_RESET:
-		case '\n':
-			state->bold = FALSE;
-			state->italic = FALSE;
-			state->underline = FALSE;
-			state->strikethrough = FALSE;
-			state->reverse = FALSE;
-			state->foreground = -1;
-			state->background = -1;
-			state->pending_foreground = FALSE;
-			state->pending_background = FALSE;
-			break;
-		case ATTR_COLOR:
-			{
-				gint value = 0;
-				gint digits = 0;
-
-				state->pending_foreground = FALSE;
-				state->pending_background = FALSE;
-
-				if (i >= limit)
-				{
-					state->pending_foreground = TRUE;
-					break;
-				}
-
-				if (!g_ascii_isdigit (text[i]))
-				{
-					state->foreground = -1;
-					state->background = -1;
-					break;
-				}
-
-				while (i < limit && digits < 2 && g_ascii_isdigit (text[i]))
-				{
-					value = (value * 10) + (text[i] - '0');
-					i++;
-					digits++;
-				}
-				state->foreground = value;
-				state->background = -1;
-
-				if (i < limit && text[i] == ',')
-				{
-					i++;
-					if (i >= limit)
-					{
-						state->pending_background = TRUE;
-						break;
-					}
-
-					value = 0;
-					digits = 0;
-					while (i < limit && digits < 2 && g_ascii_isdigit (text[i]))
-					{
-						value = (value * 10) + (text[i] - '0');
-						i++;
-						digits++;
-					}
-					if (digits > 0)
-						state->background = value;
-				}
-			}
-			break;
-		default:
-			break;
-		}
-	}
-}
-
-static void
-mg_input_format_append (GString *summary, const char *text)
-{
-	if (summary->len > 0)
-		g_string_append (summary, " · ");
-	g_string_append (summary, text);
-}
-
-static void
-mg_input_format_color_value (char *buffer, gsize buffer_len, const char *label, gint color_index)
-{
-	guint16 red;
-	guint16 green;
-	guint16 blue;
-
-	if (theme_get_mirc_color_rgb16 ((unsigned int) color_index, &red, &green, &blue))
-	{
-		g_snprintf (buffer, buffer_len,
-					"%s <b>%02d</b> <span foreground=\"#%02x%02x%02x\">■</span>",
-					label, color_index, (guint) (red >> 8), (guint) (green >> 8),
-					(guint) (blue >> 8));
-		return;
-	}
-
-	g_snprintf (buffer, buffer_len, "%s <b>%02d</b>", label, color_index);
-}
-
-static void
-mg_input_format_update (GtkEntry *entry)
-{
-	GtkWidget *format_box;
-	GtkWidget *format_label;
-	MgInputFormatState state;
-	GString *summary;
-	char color[96];
-	char *markup;
-
-	format_box = g_object_get_data (G_OBJECT (entry), "zoitechat-format-box");
-	format_label = g_object_get_data (G_OBJECT (entry), "zoitechat-format-label");
-	if (!format_box || !format_label)
-		return;
-
-	if (!prefs.hex_gui_input_attr)
-	{
-		gtk_widget_hide (format_box);
-		return;
-	}
-
-	mg_input_format_state_at_cursor (entry, &state);
-	summary = g_string_new (NULL);
-
-	if (state.bold)
-		mg_input_format_append (summary, "<b>Bold</b>");
-	if (state.italic)
-		mg_input_format_append (summary, "<i>Italic</i>");
-	if (state.underline)
-		mg_input_format_append (summary, "<u>Underline</u>");
-	if (state.strikethrough)
-		mg_input_format_append (summary, "<s>Strikethrough</s>");
-	if (state.reverse)
-		mg_input_format_append (summary, "Reverse");
-
-	if (state.foreground >= 0)
-	{
-		mg_input_format_color_value (color, sizeof (color), "Text color", state.foreground);
-		mg_input_format_append (summary, color);
-	}
-	if (state.background >= 0)
-	{
-		mg_input_format_color_value (color, sizeof (color), "Background", state.background);
-		mg_input_format_append (summary, color);
-	}
-	if (state.pending_foreground)
-		mg_input_format_append (summary, "Color: type foreground[,background]");
-	else if (state.pending_background)
-		mg_input_format_append (summary, "Background: type color");
-
-	if (summary->len == 0)
-	{
-		gtk_widget_hide (format_box);
-		g_string_free (summary, TRUE);
-		return;
-	}
-
-	markup = g_strdup_printf ("<span foreground='#7d8790'>Formatting · %s</span>", summary->str);
-	gtk_label_set_markup (GTK_LABEL (format_label), markup);
-	gtk_widget_show (format_label);
-	gtk_widget_show (format_box);
-	g_free (markup);
-	g_string_free (summary, TRUE);
-}
-
-static void
-mg_inputbox_cursor_changed (GObject *object, GParamSpec *pspec, gpointer userdata)
-{
-	(void) pspec;
-	(void) userdata;
-	mg_input_format_update (GTK_ENTRY (object));
-}
-
 static void
 mg_inputbox_changed (GtkEditable *editable, session_gui *gui)
 {
         key_check_replace_on_change (editable, NULL);
-        mg_input_format_update (GTK_ENTRY (editable));
         if (current_sess && current_sess->gui == gui)
                 mg_typing_update (current_sess, gtk_entry_get_text (GTK_ENTRY (editable)));
 }
@@ -5025,7 +4799,7 @@ mg_create_search(session *sess, GtkWidget *box)
 static void
 mg_create_entry (session *sess, GtkWidget *box)
 {
-        GtkWidget *hbox, *but, *entry, *format_box, *format_label;
+        GtkWidget *hbox, *but, *entry;
         session_gui *gui = sess->gui;
         const char *emoji_fallback_icon_names[] = {
                 "face-smile-symbolic",
@@ -5037,16 +4811,6 @@ mg_create_entry (session *sess, GtkWidget *box)
         };
         const char *emoji_fallback_icon_name;
 
-        format_box = mg_box_new (GTK_ORIENTATION_HORIZONTAL, FALSE, 6);
-        gtk_widget_set_name (format_box, "zoitechat-formatbar");
-        gtk_widget_set_no_show_all (format_box, TRUE);
-        gtk_box_pack_start (GTK_BOX (box), format_box, 0, 0, 0);
-        format_label = gtk_label_new ("");
-        gtk_label_set_ellipsize (GTK_LABEL (format_label), PANGO_ELLIPSIZE_END);
-        gtk_box_pack_start (GTK_BOX (format_box), format_label, TRUE, TRUE, 8);
-        gtk_widget_show (format_label);
-        gtk_widget_hide (format_box);
-
         gui->reply_box = mg_box_new (GTK_ORIENTATION_HORIZONTAL, FALSE, 6);
         gtk_widget_set_name (gui->reply_box, "zoitechat-replybar");
         gtk_widget_set_no_show_all (gui->reply_box, TRUE);
@@ -5077,16 +4841,12 @@ mg_create_entry (session *sess, GtkWidget *box)
         gui->input_box = entry = sexy_spell_entry_new ();
         sexy_spell_entry_set_checked ((SexySpellEntry *)entry, prefs.hex_gui_input_spell);
         sexy_spell_entry_set_parse_attributes ((SexySpellEntry *)entry, prefs.hex_gui_input_attr);
-        g_object_set_data (G_OBJECT (entry), "zoitechat-format-box", format_box);
-        g_object_set_data (G_OBJECT (entry), "zoitechat-format-label", format_label);
 
         gtk_entry_set_max_length (GTK_ENTRY (gui->input_box), 0);
         g_signal_connect (G_OBJECT (entry), "activate",
                                                         G_CALLBACK (mg_inputbox_cb), gui);
         g_signal_connect (G_OBJECT (entry), "changed",
                                                         G_CALLBACK (mg_inputbox_changed), gui);
-        g_signal_connect (G_OBJECT (entry), "notify::cursor-position",
-                                                        G_CALLBACK (mg_inputbox_cursor_changed), gui);
         gtk_box_pack_start (GTK_BOX (hbox), entry, TRUE, TRUE, 0);
 
         gtk_widget_set_name (entry, "zoitechat-inputbox");
@@ -6026,9 +5786,9 @@ void
 fe_session_callback (session *sess)
 {
         gtk_xtext_buffer_free (sess->res->buffer);
+        if (sess->res->user_row_iters)
+                g_hash_table_destroy (sess->res->user_row_iters);
         g_object_unref (G_OBJECT (sess->res->user_model));
-        if (sess->res->user_row_refs)
-                g_hash_table_destroy (sess->res->user_row_refs);
 
         if (sess->res->banlist && sess->res->banlist->window)
                 mg_close_gen (NULL, sess->res->banlist->window);

src/fe-gtk/userlistgui.c

@@ -218,75 +218,49 @@ scroll_to_iter (GtkTreeIter *iter, GtkTreeView *treeview, GtkTreeModel *model)
 static GHashTable *
 userlist_row_map_ensure (session *sess)
 {
-	if (!sess->res->user_row_refs)
+	if (!sess->res->user_row_iters)
-		sess->res->user_row_refs = g_hash_table_new_full (g_direct_hash, g_direct_equal, NULL, (GDestroyNotify) gtk_tree_row_reference_free);
+		sess->res->user_row_iters = g_hash_table_new_full (g_direct_hash, g_direct_equal, NULL, (GDestroyNotify) gtk_tree_iter_free);
 
-	return sess->res->user_row_refs;
+	return sess->res->user_row_iters;
 }
 
 static void
 userlist_row_map_remove (session *sess, struct User *user)
 {
-	if (!sess->res->user_row_refs)
+	if (!sess->res->user_row_iters)
 		return;
 
-	g_hash_table_remove (sess->res->user_row_refs, user);
+	g_hash_table_remove (sess->res->user_row_iters, user);
 }
 
 static void
 userlist_row_map_set (session *sess, GtkTreeModel *model, struct User *user, GtkTreeIter *iter)
 {
-	GtkTreePath *path;
+	/* The shared tree view can still show another session's model while a
-	GtkTreeRowReference *ref;
+	 * tab switch is pending. Never cache an iterator from that model. */
-
+	if (model != GTK_TREE_MODEL (sess->res->user_model))
-	path = gtk_tree_model_get_path (model, iter);
-	if (!path)
 		return;
 
-	ref = gtk_tree_row_reference_new (model, path);
+	/* GtkListStore guarantees persistent iterators until their row is
-	gtk_tree_path_free (path);
+	 * removed, including across sorting. Unlike row references, these do
-	if (!ref)
+	 * not require every cached position to be updated on each insertion. */
-		return;
+	g_hash_table_replace (userlist_row_map_ensure (sess), user, gtk_tree_iter_copy (iter));
-
-	g_hash_table_replace (userlist_row_map_ensure (sess), user, ref);
 }
 
 static gboolean
 userlist_row_map_get_iter (session *sess, GtkTreeModel *model, struct User *user, GtkTreeIter *iter)
 {
-	GtkTreeRowReference *ref;
+	GtkTreeIter *cached;
-	GtkTreePath *path;
-	struct User *row_user;
 
-	if (!sess->res->user_row_refs)
+	if (model != GTK_TREE_MODEL (sess->res->user_model) || !sess->res->user_row_iters)
 		return FALSE;
 
-	ref = g_hash_table_lookup (sess->res->user_row_refs, user);
+	cached = g_hash_table_lookup (sess->res->user_row_iters, user);
-	if (!ref)
+	if (!cached)
 		return FALSE;
 
-	path = gtk_tree_row_reference_get_path (ref);
+	/* Removal and clear invalidate the cache before deleting model rows. */
-	if (!path)
+	*iter = *cached;
-	{
-		g_hash_table_remove (sess->res->user_row_refs, user);
-		return FALSE;
-	}
-
-	if (!gtk_tree_model_get_iter (model, iter, path))
-	{
-		gtk_tree_path_free (path);
-		g_hash_table_remove (sess->res->user_row_refs, user);
-		return FALSE;
-	}
-	gtk_tree_path_free (path);
-
-	gtk_tree_model_get (model, iter, COL_USER, &row_user, -1);
-	if (row_user != user)
-	{
-		g_hash_table_remove (sess->res->user_row_refs, user);
-		return FALSE;
-	}
-
 	return TRUE;
 }
 
@@ -587,7 +561,6 @@ fe_userlist_rehash (session *sess, struct User *user)
 					  GTK_TREE_MODEL(sess->res->user_model), user, &sel);
 	if (!iter)
 		return;
-	userlist_row_map_set (sess, GTK_TREE_MODEL (sess->res->user_model), user, iter);
 
 	if (prefs.hex_away_track && user->away)
 	{
@@ -698,8 +671,8 @@ fe_userlist_insert (session *sess, struct User *newuser, gboolean sel)
 void
 fe_userlist_clear (session *sess)
 {
-	if (sess->res->user_row_refs)
+	if (sess->res->user_row_iters)
-		g_hash_table_remove_all (sess->res->user_row_refs);
+		g_hash_table_remove_all (sess->res->user_row_iters);
 	gtk_list_store_clear (sess->res->user_model);
 }
 

src/fe-gtk/xtext.c

@@ -3130,6 +3130,7 @@ gtk_xtext_class_init (GtkXTextClass * class)
 
 typedef struct chunk_s {
 	GSList *slp;
+	gboolean collect_metadata;
 	int off1, len1, emph;
 	offlen_t meta;
 } chunk_t;
@@ -3142,12 +3143,19 @@ xtext_do_chunk(chunk_t *c)
 	if (c->len1 == 0)
 		return;
 
+	/* Copying, searching and saving only need the stripped text. */
+	if (!c->collect_metadata)
+	{
+		c->len1 = 0;
+		return;
+	}
+
 	meta = g_new (offlen_t, 1);
 	meta->off = c->off1;
 	meta->len = c->len1;
 	meta->emph = c->emph;
 	meta->width = 0;
-	c->slp = g_slist_append (c->slp, meta);
+	c->slp = g_slist_prepend (c->slp, meta);
 
 	c->len1 = 0;
 }
@@ -3170,6 +3178,7 @@ gtk_xtext_strip_color (unsigned char *text, int len, unsigned char *outbuf,
 		new_str = outbuf;
 
 	c.slp = NULL;
+	c.collect_metadata = slpp != NULL;
 	c.off1 = 0;
 	c.len1 = 0;
 	c.emph = 0;
@@ -3240,9 +3249,7 @@ bad_utf8:		/* Normal ending sequence, and give up if bad utf8 */
 		*newlen = i;
 
 	if (slpp)
-		*slpp = c.slp;
+		*slpp = g_slist_reverse (c.slp);
-	else
-		g_slist_free_full (c.slp, g_free);
 
 	return new_str;
 }
@@ -4341,7 +4348,7 @@ gtk_xtext_lines_taken (xtext_buffer *buf, textentry * ent)
 
 	if (win_width >= ent->indent + ent->str_width)
 	{
-		ent->sublines = g_slist_append (ent->sublines, GINT_TO_POINTER (ent->str_len));
+		ent->sublines = g_slist_prepend (ent->sublines, GINT_TO_POINTER (ent->str_len));
 		ent->subline_count = 1;
 		return ent->subline_count;
 	}
@@ -4352,13 +4359,15 @@ gtk_xtext_lines_taken (xtext_buffer *buf, textentry * ent)
 	do
 	{
 		len = find_next_wrap (buf->xtext, ent, str, win_width, indent);
-		ent->sublines = g_slist_append (ent->sublines, GINT_TO_POINTER (str + len - ent->str));
+		ent->sublines = g_slist_prepend (ent->sublines, GINT_TO_POINTER (str + len - ent->str));
+		ent->subline_count++;
 		indent = buf->indent;
 		str += len;
 	}
 	while (str < ent->str + ent->str_len);
 
-	ent->subline_count = g_slist_length (ent->sublines);
+	/* Preserve display order without walking the growing list per wrap. */
+	ent->sublines = g_slist_reverse (ent->sublines);
 	return ent->subline_count;
 }