From 2b4e79faa7c5c47be31346241ed38714c854ac96 Mon Sep 17 00:00:00 2001 From: Eli Schwartz Date: Tue, 27 Oct 2026 12:07:09 -0400 Subject: [PATCH] meson: explicitly mark run_command as fallible when returncode is checked Meson emits a warning stating that the default will change from false to true, in some future version, and that one should always pass `check: BOOL` explicitly. Normally this is because commands that unexpectedly fail would result in wrong behavior if the build treats it as though it succeeded. In this case, we were specifically relying on it being `check: false`, as the returncode is immediately checked in order to provide a better error message. Make this explicit in the meson.build file. Signed-off-by: Eli Schwartz --- plugins/perl/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/perl/meson.build b/plugins/perl/meson.build index 95421a06..a2d215ef 100644 --- a/plugins/perl/meson.build +++ b/plugins/perl/meson.build @@ -28,7 +28,7 @@ endif perl = find_program(get_option('with-perl')) -ret = run_command([perl, '-MExtUtils::Embed', '-e', 'ccopts']) +ret = run_command([perl, '-MExtUtils::Embed', '-e', 'ccopts'], check: false) if ret.returncode() != 0 error('perl: Failed to get cflags') endif @@ -38,7 +38,7 @@ foreach flag : ret.stdout().strip().split(' ') endif endforeach -ret = run_command([perl, '-MExtUtils::Embed', '-e', 'ldopts']) +ret = run_command([perl, '-MExtUtils::Embed', '-e', 'ldopts'], check: false) if ret.returncode() != 0 error('perl: Failed to get ldflags') endif