Files
ttrv/CONTRIBUTING.rst
2024-03-08 16:51:35 +00:00

4.1 KiB

<?xml version="1.0" encoding="utf-8" ?> <html xmlns="http://www.w3.org/1999/xhtml" xml:lang="en" lang="en"> <head> <style type="text/css"> /* :Author: David Goodger (goodger@python.org) :Id: $Id: html4css1.css 8954 2022-01-20 10:10:25Z milde $ :Copyright: This stylesheet has been placed in the public domain. Default cascading style sheet for the HTML output of Docutils. See https://docutils.sourceforge.io/docs/howto/html-stylesheets.html for how to customize this style sheet. */ /* used to remove borders from tables and images */ .borderless, table.borderless td, table.borderless th { border: 0 } table.borderless td, table.borderless th { /* Override padding for "table.docutils td" with "! important". The right padding separates the table cells. */ padding: 0 0.5em 0 0 ! important } .first { /* Override more specific margin styles with "! important". */ margin-top: 0 ! important } .last, .with-subtitle { margin-bottom: 0 ! important } .hidden { display: none } .subscript { vertical-align: sub; font-size: smaller } .superscript { vertical-align: super; font-size: smaller } a.toc-backref { text-decoration: none ; color: black } blockquote.epigraph { margin: 2em 5em ; } dl.docutils dd { margin-bottom: 0.5em } object[type="image/svg+xml"], object[type="application/x-shockwave-flash"] { overflow: hidden; } /* Uncomment (and remove this text!) to get bold-faced definition list terms dl.docutils dt { font-weight: bold } */ div.abstract { margin: 2em 5em } div.abstract p.topic-title { font-weight: bold ; text-align: center } div.admonition, div.attention, div.caution, div.danger, div.error, div.hint, div.important, div.note, div.tip, div.warning { margin: 2em ; border: medium outset ; padding: 1em } div.admonition p.admonition-title, div.hint p.admonition-title, div.important p.admonition-title, div.note p.admonition-title, div.tip p.admonition-title { font-weight: bold ; font-family: sans-serif } div.attention p.admonition-title, div.caution p.admonition-title, div.danger p.admonition-title, div.error p.admonition-title, div.warning p.admonition-title, .code .error { color: red ; font-weight: bold ; font-family: sans-serif } /* Uncomment (and remove this text!) to get reduced vertical space in compound paragraphs. div.compound .compound-first, div.compound .compound-middle { margin-bottom: 0.5em } div.compound .compound-last, div.compound .compound-middle { margin-top: 0.5em } */ div.dedication { margin: 2em 5em ; text-align: center ; font-style: italic } div.dedication p.topic-title { font-weight: bold ; font-style: normal } div.figure { margin-left: 2em ; margin-right: 2em } div.footer, div.header { clear: both; font-size: smaller } div.line-block { display: block ; margin-top: 1em ; margin-bottom: 1em } div.line-block div.line-block { margin-top: 0 ; margin-bottom: 0 ; margin-left: 1.5em } div.sidebar { margin: 0 0 0.5em 1em ; border: medium outset ; padding: 1em ; background-color: #ffffee ; width: 40% ; float: right ; clear: right } div.sidebar p.rubric { font-family: sans-serif ; font-size: medium } div.system-messages { margin: 5em } div.system-messages h1 { color: red } div.system-message { border: medium outset ; padding: 1em } div.system-message p.system-message-title { color: red ; font-weight: bold } div.topic { margin: 2em } h1.section-subtitle, h2.section-subtitle, h3.section-subtitle, h4.section-subtitle, h5.section-subtitle, h6.section-subtitle { margin-top: 0.4em } h1.title { text-align: center } h2.subtitle { text-align: center } hr.docutils { width: 75% } img.align-left, .figure.align-left, object.align-left, table.align-left { clear: left ; float: left ; margin-right: 1em } img.align-right, .figure.align-right, object.align-right, table.align-right { clear: right ; float: right ; margin-left: 1em } img.align-center, .figure.align-center, object.align-center { display: block; margin-left: auto; margin-right: auto; } table.align-center { margin-left: auto; margin-right: auto; } .align-left { text-align: left } .align-center { clear: both ; text-align: center } .align-right { text-align: right } /* reset inner alignment in figures */ div.align-right { text-align: inherit } /* div.align-center * { */ /* text-align: left } */ .align-top { vertical-align: top } .align-middle { vertical-align: middle } .align-bottom { vertical-align: bottom } ol.simple, ul.simple { margin-bottom: 1em } ol.arabic { list-style: decimal } ol.loweralpha { list-style: lower-alpha } ol.upperalpha { list-style: upper-alpha } ol.lowerroman { list-style: lower-roman } ol.upperroman { list-style: upper-roman } p.attribution { text-align: right ; margin-left: 50% } p.caption { font-style: italic } p.credits { font-style: italic ; font-size: smaller } p.label { white-space: nowrap } p.rubric { font-weight: bold ; font-size: larger ; color: maroon ; text-align: center } p.sidebar-title { font-family: sans-serif ; font-weight: bold ; font-size: larger } p.sidebar-subtitle { font-family: sans-serif ; font-weight: bold } p.topic-title { font-weight: bold } pre.address { margin-bottom: 0 ; margin-top: 0 ; font: inherit } pre.literal-block, pre.doctest-block, pre.math, pre.code { margin-left: 2em ; margin-right: 2em } pre.code .ln { color: grey; } /* line numbers */ pre.code, code { background-color: #eeeeee } pre.code .comment, code .comment { color: #5C6576 } pre.code .keyword, code .keyword { color: #3B0D06; font-weight: bold } pre.code .literal.string, code .literal.string { color: #0C5404 } pre.code .name.builtin, code .name.builtin { color: #352B84 } pre.code .deleted, code .deleted { background-color: #DEB0A1} pre.code .inserted, code .inserted { background-color: #A3D289} span.classifier { font-family: sans-serif ; font-style: oblique } span.classifier-delimiter { font-family: sans-serif ; font-weight: bold } span.interpreted { font-family: sans-serif } span.option { white-space: nowrap } span.pre { white-space: pre } span.problematic { color: red } span.section-subtitle { /* font-size relative to parent (h1..h6 element) */ font-size: 80% } table.citation { border-left: solid 1px gray; margin-left: 1px } table.docinfo { margin: 2em 4em } table.docutils { margin-top: 0.5em ; margin-bottom: 0.5em } table.footnote { border-left: solid 1px black; margin-left: 1px } table.docutils td, table.docutils th, table.docinfo td, table.docinfo th { padding-left: 0.5em ; padding-right: 0.5em ; vertical-align: top } table.docutils th.field-name, table.docinfo th.docinfo-name { font-weight: bold ; text-align: left ; white-space: nowrap ; padding-left: 0 } /* "booktabs" style (no vertical lines) */ table.docutils.booktabs { border: 0px; border-top: 2px solid; border-bottom: 2px solid; border-collapse: collapse; } table.docutils.booktabs * { border: 0px; } table.docutils.booktabs th { border-bottom: thin solid; text-align: left; } h1 tt.docutils, h2 tt.docutils, h3 tt.docutils, h4 tt.docutils, h5 tt.docutils, h6 tt.docutils { font-size: 100% } ul.auto-toc { list-style-type: none } </style> </head>

Contributor Guidelines

Before you start

  • Post an issue on the tracker describing the bug or feature you would like to add
  • If an issue already exists, leave a comment to let others know that you intend to work on it

Considerations

  • One of the project's goals is to maintain compatibility with as many terminal emulators as possible. Please be mindful of this when designing a new feature
    • Is it compatible with both Linux and OS X?
    • Is it compatible with both Python 2 and Python 3
    • Will it work over ssh (without X11)?
    • What about terminals that don't support color? Or in those with limited (8/256) colors?
    • Will it work in tmux/screen?
    • Will is fail gracefully if unicode is not supported?
  • If you're adding a new feature, try to include a few test cases. See the section below on setting up your test environment
  • If you tried, but you can't get the tests running in your environment, it's ok
  • If you are unsure about anything, ask!

Submitting a pull request

  • Reference the issue # that the pull request is related to
  • Make sure you have merged in the latest changes from the master branch
  • After you submit, make sure that the Travis-CI build passes
  • Be prepared to have your code reviewed. For non-trivial additions, it's normal for this process to take a few iterations

Style guide

  • All code should follow PEP 8

  • Try to keep lines under 80 characters, but don't sacrifice readability to do it!

    Ugly

    System Message: WARNING/2 (<stdin>, line 46)

    Cannot analyze code. Pygments package not found.

    .. code-block:: python
    
                text = ''.join(
                    line for line in fp2 if not line.startswith('#'))
    
    

    Better

    System Message: WARNING/2 (<stdin>, line 53)

    Cannot analyze code. Pygments package not found.

    .. code-block:: python
    
              text = ''.join(line for line in fp2 if not line.startswith('#'))
    
    
  • Use the existing codebase as a reference when writing docstrings (adopted from the Google Style Guide)

  • Add an encoding header # -*- coding: utf-8 -*- to all new files

  • Please don't submit pull requests for style-only code changes

Running the tests

This project uses pytest and VCR.py

VCR is a tool that records HTTP requests made during the test run and stores them in tests/cassettes for subsequent runs. This both speeds up the tests and helps to maintain consistency across runs.

  1. Install the test dependencies

    System Message: WARNING/2 (<stdin>, line 71)

    Cannot analyze code. Pygments package not found.

    .. code-block:: bash
    
       $ pip install ttrv[test]
    
    
  2. Set your $PYTHONPATH to point to the directory of your ttrv repository.

    System Message: WARNING/2 (<stdin>, line 77)

    Cannot analyze code. Pygments package not found.

    .. code-block:: bash
    
      $ export PYTHONPATH=~/code/ttrv/
    
    
  3. Run the tests using the existing cassettes

    System Message: WARNING/2 (<stdin>, line 83)

    Cannot analyze code. Pygments package not found.

    .. code-block:: bash
    
      $ python -m pytest ~/code/ttrv/tests/
      ================================ test session starts ================================
      platform linux -- Python 3.4.0, pytest-2.9.2, py-1.4.31, pluggy-0.3.1
      rootdir: ~/code/ttrv/, inifile:
      plugins: xdist-1.14, cov-2.2.0
      collected 113 items
    
    
  4. By default, the cassettes will act as read-only. If you have written a new test and would like to record a cassette, you must provide your own refresh token. The easiest thing to do is to use the token generated by ttrv when you log in. This is usually stored as ~/.local/share/ttrv/refresh-token.

    System Message: WARNING/2 (<stdin>, line 97)

    Cannot analyze code. Pygments package not found.

    .. code-block:: bash
    
       $ python -m pytest ~/code/ttrv/tests/ --record-mode once --refresh-token ~/.local/share/ttrv/refresh-token
       ================================ test session starts ================================
       platform linux -- Python 3.4.0, pytest-2.9.2, py-1.4.31, pluggy-0.3.1
       rootdir: ~/code/ttrv/, inifile:
       plugins: xdist-1.14, cov-2.2.0
       collected 113 items
    
    

    Note that all sensitive information will automatically be stripped from the cassette when it's saved.

  5. Once you have generated a new cassette, go ahead and commit it to your branch along with your test case

</html>